Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing license to completion.go #119

Merged
merged 1 commit into from
May 20, 2019
Merged

Adds missing license to completion.go #119

merged 1 commit into from
May 20, 2019

Conversation

navidshaikh
Copy link
Collaborator

as per title

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
@knative-prow-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhuss
Copy link
Contributor

rhuss commented May 17, 2019

lgtm

@cppforlife
Copy link

/ok-to-test
/lgtm
/approve

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@knative-prow-robot knative-prow-robot merged commit a264f06 into knative:master May 20, 2019
@navidshaikh navidshaikh deleted the add-license branch May 21, 2019 09:09
rhuss pushed a commit to rhuss/knative-client that referenced this pull request May 27, 2019
@navidshaikh @rhuss
Adds missing license to completion.go (knative#119)
074acdb
maximilien pushed a commit to maximilien/client that referenced this pull request May 28, 2019
@navidshaikh @maximilien
Adds missing license to completion.go (knative#119)
e202376
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Oct 18, 2019
@openshift-merge-robot
Merge pull request knative#119 from navidshaikh/pr/serverless-operator
054a704 
Uses serverless operator to setup knative serving
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Add e2e test (knative#119)
ce1328a 
Current (only) test verifies the `e2e-tests.sh` helper script.

Fixes knative#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@cppforlife cppforlife

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navidshaikh @knative-prow-robot @rhuss @cppforlife